[UT] Include iomanip if not defined #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nileshnegi <[email protected]>
nileshnegi
requested review from
wenkaidu,
gilbertlee-amd,
akolliasAMD,
edgargabriel,
PedramAlizadeh,
nusislam,
KawtharShafie,
AtlantaPepsi,
mberenjk,
corey-derochie-amd,
mustafabar,
thananon,
JhaShweta1 and
haripriya-amd
as code owners
mustafabar
approved these changes
Jan 29, 2025
corey-derochie-amd
requested changes
Jan 30, 2025
`iomanip.h` has pre-defined include guards. These are not needed. Co-authored-by: corey-derochie-amd <[email protected]>
corey-derochie-amd
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Work item:
#1455
What were the changes?
If undefined, include the
iomanipheader file in RCCL UnitTestsWhy were the changes made?
Newer versions of GTest (like 1.15) do not include
iomanipas part ofgtest/internal/gtest-internal.h.This can cause build failures for RCCL UnitTests (due to lack of symbols
std::setfillandstd::setw) if one uses pre-installed GTest (and does not build release-1.11.0 as part of RCCL dependencies).Approval Checklist
Do not approve until these items are satisfied.